Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move lib/file-finder.js to lib/util/ (refs #10559) #10695

Merged
merged 1 commit into from
Jul 29, 2018

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Move lib/file-finder.js to lib/util/file-finder.js.

What changes did you make? (Give an overview)

Renamed lib/file-finder.js to lib/util/file-finder.js along with its associated test file.

Is there anything you'd like reviewers to focus on?

Not really.

@platinumazure platinumazure added the chore This change is not user-facing label Jul 29, 2018
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 5984820 into master Jul 29, 2018
@platinumazure platinumazure deleted the move-file-finder branch July 29, 2018 03:18
noqcks pushed a commit to noqcks/codeclimate-eslint that referenced this pull request Oct 22, 2018
filipesperandio pushed a commit to codeclimate/codeclimate-eslint that referenced this pull request Nov 5, 2018
* upgrade eslint-plugin-react (7.7.0 -> 7.11.0)

* The experimentalObjectRestSpread option has been deprecated

https://eslint.org/docs/user-guide/migrating-to-5.0.0#-the-experimentalobjectrestspread-option-has-been-deprecated

* nodejs 4 is no longer supported

https://eslint.org/docs/user-guide/migrating-to-5.0.0#drop-node-4

* file-finder has moved to util/file-finder

eslint/eslint#10695

* removing invalidplugin from eslintrc.yml because of failure

AssertionError: expected [Function: executeUnsupportedPlugins] to not
throw an error but 'Error: Cannot find module
\'eslint-plugin-invalidplugin\'\nReferenced from:
/usr/src/app/integration/with_unsupported_plugins/eslintrc.yml' was thrown
at Context.<anonymous> (integration/eslint_test.js:30:53)

* updating README/package.json with eslint 5 updates

* upgrading output_mess with eslint 5 config

https://eslint.org/docs/user-guide/migrating-to-5.0.0#-the-experimentalobjectrestspread-option-has-been-deprecated

* sorting packages in README

* adding eslint-config-secure

* removing eslint-config-secure from the README of broken packages

* removing eslint-config-secure again

* Add fresh yarn.lock (#1)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 26, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants