Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests about .eslintignore file are failing on Windows #10687

Closed
mysticatea opened this issue Jul 27, 2018 · 0 comments · Fixed by #10691
Closed

Some tests about .eslintignore file are failing on Windows #10687

mysticatea opened this issue Jul 27, 2018 · 0 comments · Fixed by #10691
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features

Comments

@mysticatea
Copy link
Member

Tell us about your environment

  • ESLint Version: master
  • Node Version: 10.4.0
  • npm Version: 6.1.0

What parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:

N/A

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

npm test on our repo.

What did you expect to happen?

Tests are passed.

What actually happened? Please include the actual, raw output from ESLint.

> npm i; npm t
npm WARN eslint-plugin-es@1.3.1 requires a peer of eslint@>=4.19.1 but none is installed. You must install peer dependencies yourself.
npm WARN eslint-plugin-eslint-plugin@1.4.0 requires a peer of eslint@>=4.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN eslint-plugin-node@7.0.1 requires a peer of eslint@>=4.19.1 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

updated 1 package and audited 6116 packages in 12.179s
found 12 vulnerabilities (4 low, 6 moderate, 2 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

> eslint@5.2.0 test C:\Users\starc\Documents\GitHub\eslint
> node Makefile.js test

Validating Makefile.js
Validating .eslintrc.js
Validating JSON Files
Validating Markdown Files
Validating JavaScript files
Validating JavaScript test files
Validating rules
Running unit tests

  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬...](node:10708) [ESLINT_LEGACY_ECMAFEATURES] DeprecationWarning: The 'ecmaFeatures' config file property is deprecated, and has no effect. (found in "tests\fixtures\config-file\ecma-features\.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests\fixtures\config-file\experimental-object-rest-spread\basic\.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests\fixtures\config-file\experimental-object-rest-spread\subdir\.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests\fixtures\config-file\experimental-object-rest-spread\extends\common.yml")
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬.]


  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬](node:10708) [DEP0094] DeprecationWarning: assert.fail() with more than one argument is deprecated. Please use assert.strictEqual() instead or only pass a message.
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬]

  18351 passing (1m)
  4 failing

  1) CLIEngine
       executeOnFiles()
         should ignore one-level down node_modules when ignore file has 'node_modules/' in it:

      AssertionError: expected 2 to equal 1
      + expected - actual

      -2
      +1

      at Context.it (tests\lib\cli-engine.js:1107:20)

  2) CLIEngine
       executeOnFiles()
         should ignore all files and throw an error when tests/fixtures/ is in ignore file:
     AssertionError: expected [Function] to throw an error
      at Context.it (tests\lib\cli-engine.js:1124:20)

  3) IgnoredPaths
       initialization
         should load .eslintignore from cwd when explicitly passed:
     AssertionError: expected [ Array(5) ] to include 'sampleignorepattern'
      at Context.it (tests\lib\ignored-paths.js:128:20)

  4) IgnoredPaths
       initialization with ignorePath containing commented lines
         should not include comments in ignore rules:
     AssertionError: expected [ Array(5) ] to include 'this_one_not'
      at Context.it (tests\lib\ignored-paths.js:453:20)



=============================================================================
Writing coverage object [C:\Users\starc\Documents\GitHub\eslint\coverage\coverage.json]
Writing coverage reports at [C:\Users\starc\Documents\GitHub\eslint\coverage]
=============================================================================

=============================== Coverage summary ===============================
Statements   : 99.29% ( 14358/14460 ), 165 ignored
Branches     : 98.26% ( 11051/11247 ), 122 ignored
Functions    : 99.71% ( 2427/2434 ), 28 ignored
Lines        : 99.29% ( 14213/14314 )
================================================================================
C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\src\common.js:401
      if (config.fatal) throw e;
                        ^

Error: exec: (node:10708) [ESLINT_LEGACY_ECMAFEATURES] DeprecationWarning: The 'ecmaFeatures' config file property is deprecated, and has
no effect. (found in "tests/fixtures/config-file/ecma-features/.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests/fixtures/config-file/experimental-object-rest-spread/basic/.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests/fixtures/config-file/experimental-object-rest-spread/subdir/.eslintrc.yml")
(node:10708) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "tests/fixtures/config-file/experimental-object-rest-spread/extends/common.yml")



(node:10708) [DEP0094] DeprecationWarning: assert.fail() with more than one argument is deprecated. Please use assert.strictEqual() instead or only pass a message.
=============================================================================
Writing coverage object [C:/Users/starc/Documents/GitHub/eslint/coverage/coverage.json]
Writing coverage reports at [C:/Users/starc/Documents/GitHub/eslint/coverage]
=============================================================================

    at Object.error (C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\src\common.js:110:27)
    at execSync (C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\src\exec.js:99:12)
    at _exec (C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\src\exec.js:202:12)
    at C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\src\common.js:335:23
    at Function.target.test (C:\Users\starc\Documents\GitHub\eslint\Makefile.js:602:18)
    at Object.global.target.(anonymous function) [as test] (C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\make.js:36:40)
    at C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\make.js:48:27
    at Array.forEach (<anonymous>)
    at Timeout._onTimeout (C:\Users\starc\Documents\GitHub\eslint\node_modules\shelljs\make.js:46:10)
    at ontimeout (timers.js:427:11)
npm ERR! Test failed.  See above for more details.
@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 27, 2018
@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 28, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant