Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to remove some deprecated/unmaintained deps #10684

Closed
aladdin-add opened this issue Jul 26, 2018 · 4 comments
Closed

try to remove some deprecated/unmaintained deps #10684

aladdin-add opened this issue Jul 26, 2018 · 4 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process needs bikeshedding Minor details about this change need to be discussed

Comments

@aladdin-add
Copy link
Member

aladdin-add commented Jul 26, 2018

To some extend, deprecated deps mean unhealthy. While I'm not seeing depth=1 deprecated deps in eslint, but

I think it make sense to upgrade/remove these deps. a few thoughts on this(and want to get help from the community ✋ ):

  • find out deprecated/unmaintained deps.
  • if still maintained, upgrade to latest.
  • if not maintained, find a high-quality alternate.
  • if can't find a qualified alternate, write own.
  • or keep it. ◑﹏◐

refs:

@aladdin-add aladdin-add added infrastructure Relates to the tools used in the ESLint development process needs bikeshedding Minor details about this change need to be discussed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 26, 2018
@mysticatea
Copy link
Member

About levn, I don't think we should change it because it's a part of our public API (it parses CLI arguments and /*eslint ...*/ directives).

About deprecated indirect dependencies, those seem to come from beefy, karma, and sinon.

> npm ls leftpad formatio nodemailer wrench uws mailcomposer socks node-uuid buildmail
eslint@5.2.0 C:\Users\starc\Documents\GitHub\eslint
+-- beefy@2.1.8
| `-- leftpad@0.0.0
+-- karma@2.0.5
| +-- log4js@2.11.0
| | +-- loggly@1.1.1
| | | `-- request@2.75.0
| | |   `-- node-uuid@1.4.8
| | +-- mailgun-js@0.18.1
| | | `-- proxy-agent@3.0.1
| | |   +-- pac-proxy-agent@2.0.2
| | |   | `-- socks-proxy-agent@3.0.1
| | |   |   `-- socks@1.1.10
| | |   `-- socks-proxy-agent@4.0.1
| | |     `-- socks@2.2.1
| | `-- nodemailer@2.7.2
| |   +-- mailcomposer@4.0.1
| |   | `-- buildmail@4.0.1
| |   `-- socks@1.1.9
| `-- socket.io@2.0.4
|   `-- engine.io@3.1.5
|     `-- uws@9.14.0
`-- sinon@3.3.0
  +-- build@0.1.4
  | `-- wrench@1.3.9
  `-- formatio@1.2.0

  • I'm not sure what does beefy do. Can we remove it?
  • We are using the latest karma, but most deprecated dependencies come from karma. Probably we have to find an alternative for karma and phantomjs. Maybe puppeteer and ...? As a side note, we should consider drop the support of IE11 for our online demo since we cannot test for ES5 environment if we switch phantomjs.
  • We are using very old sinon. Upgrading may solve it.

@aladdin-add
Copy link
Member Author

@mysticatea thanks for you feedback!

👍 to switch to puppeteer, and upgrade sinon.

As for levn, I should have given more background. There is a known issue (#9366). We might need to make a decision to:

  • fork the repo, and fix the bug (though it was written in livescript).
  • or implement our own, and passed its tests.
  • or another way?

@mysticatea
Copy link
Member

Should we open an issue on the levn repo at first? Because that repo has no issue in a long time, it means they have not needed to change their code.

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Dec 11, 2018
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 10, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process needs bikeshedding Minor details about this change need to be discussed
Projects
None yet
Development

No branches or pull requests

2 participants