Fix: The "../.." folder is always ignored (fixes #10675) #10682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
aladdin-add
added
bug
|
Could you please add a unit test that would fail without this change, but pass with this change? Thanks! |
platinumazure
approved these changes
Jul 28, 2018
not-an-aardvark
suggested changes
Jul 28, 2018
| @@ -644,6 +644,9 @@ describe("IgnoredPaths", () => { | |||
| assert.isTrue(shouldIgnore(resolve("bower_components/a/b"))); | |||
| assert.isFalse(shouldIgnore(resolve(".hidden"))); | |||
| assert.isTrue(shouldIgnore(resolve(".hidden/a"))); | |||
|
|
|||
| assert.isFalse(shouldIgnore(resolve(".."))); | |||
| assert.isFalse(shouldIgnore(resolve("../.."))); | |||
There was a problem hiding this comment.
Can you also add tests for these related cases?
../foo
../../..
../../foo
I think none of them should be ignored.
platinumazure
approved these changes
Jul 28, 2018
not-an-aardvark
approved these changes
Jul 29, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ x ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#10675
What changes did you make? (Give an overview)
Only the parent folder was excluded. Added '*' at end to exclude parent of parent directory.
Is there anything you'd like reviewers to focus on?