New: add no-async-promise-executor rule (fixes #10217) #10661
Conversation
not-an-aardvark
added
rule
|
|
||
| ## Rule Details | ||
|
|
||
| This rule aims to... |
There was a problem hiding this comment.
Oops, I was aiming for concise documentation but I think I overdid it.
| meta: { | ||
| docs: { | ||
| description: "disallow using an async function as a Promise executor", | ||
| category: "Fill me in", |
There was a problem hiding this comment.
This should probably be Possible Errors
| return { | ||
| "NewExpression[callee.name='Promise'][arguments.0.async=true]"(node) { | ||
| context.report({ | ||
| node: context.getSourceCode().getFirstToken(node.arguments[0]), |
There was a problem hiding this comment.
I imagine this wouldn't point at the right token if the node is surrounded by parens?
There was a problem hiding this comment.
I think it still would be. I'll add a test.
There was a problem hiding this comment.
Well, I'm wondering if we should just use context.getSourceCode().getFirstToken(node.arguments[0], { filter: t => t.value === "async" }) or similar to be absolutely safe.
I think it's more common for people to do things like |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[x] New rule (#10217)
What changes did you make? (Give an overview)
This implements the
no-async-promise-executorrule, as described in #10217.Is there anything you'd like reviewers to focus on?
Nothing in particular