Fix: ESLint crash with prefer-object-spread (fixes #10646) #10649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
bug
platinumazure
approved these changes
Jul 22, 2018
not-an-aardvark
suggested changes
Jul 22, 2018
lib/rules/prefer-object-spread.js
Outdated
| const leftRange = [left.range[0], getEndWithSpaces(left, sourceCode)]; | ||
| const rightRange = [getStartWithSpaces(right, sourceCode), right.range[1]]; | ||
|
|
||
| // https://github.com/eslint/eslint/issues/10646 |
There was a problem hiding this comment.
Can the comment describe what the code is doing here (e.g. "Ensure ranges don't overlap") rather than linking to an issue? I think it's probably not very good for code readability to need to click on a URL to find why the code is doing something, unless the behavior is very obscure. (In my opinion, URLs are fine in tests because the behavior itself is clearly described by the test code, but that's not always the case for comments in implementation code.)
lib/rules/prefer-object-spread.js
Outdated
| yield fixer.removeRange([left.range[0], getEndWithSpaces(left, sourceCode)]); | ||
| yield fixer.removeRange([getStartWithSpaces(right, sourceCode), right.range[1]]); | ||
| const leftRange = [left.range[0], getEndWithSpaces(left, sourceCode)]; | ||
| const rightRange = [getStartWithSpaces(right, sourceCode), right.range[1]]; |
There was a problem hiding this comment.
Nitpick: Instead of mutating rightRange, could the Math.max call be inlined?
const rightRange = [
Math.max(getStartWithSpaces(right, sourceCode), leftRange[1]),
right.range[1]
];
|
Merged, thanks for contributing! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fixes #10646
Is there anything you'd like reviewers to focus on?
no