Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: fix npm run perf failing(fixes #10577) #10607

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Build: fix npm run perf failing(fixes #10577) #10607

merged 1 commit into from
Jul 20, 2018

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jul 14, 2018 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
fixes #10577

Is there anything you'd like reviewers to focus on?

not sure why got this error, but it did fix the issue.

@aladdin-add aladdin-add added bug ESLint is working incorrectly build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Jul 14, 2018
platinumazure
platinumazure approved these changes Jul 14, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've tested this branch locally with both npm run perf and npm test and everything passes.

I'd like to leave this open for a few more days to allow others to review, since this doesn't block any other work.

@not-an-aardvark not-an-aardvark merged commit c517b2a into master Jul 20, 2018
@not-an-aardvark not-an-aardvark deleted the issue10577 branch July 20, 2018 02:02
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 17, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run perf got error
4 participants
@aladdin-add @platinumazure @ilyavolodin @not-an-aardvark