Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix error message in eslint-config-eslint #10588

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

aladdin-add
Copy link
Member

no-restricted-properties error message should be "Use assert.deepStrictEqual instead of assert.deepEqual."

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

no-restricted-properties error message should be "Use assert.deepStrictEqual instead of assert.deepEqual."
@aladdin-add aladdin-add added the chore This change is not user-facing label Jul 10, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure
Copy link
Member

Once this is merged, should we cut a patch release of eslint-config-eslint? I could probably find time to do that today or tomorrow.

@platinumazure platinumazure merged commit e4e7ff2 into master Jul 11, 2018
@platinumazure platinumazure deleted the Aladdin-ADD-patch-2 branch July 11, 2018 15:03
@platinumazure
Copy link
Member

Merged, thanks for contributing!

@platinumazure
Copy link
Member

I've released eslint-config-eslint version 5.0.1 with this change. @aladdin-add Would you mind checking to see if it worked? Thanks!

@aladdin-add
Copy link
Member Author

seems great, thanks!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 8, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants