Build: Adding rc release script to package.json #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
added
accepted
platinumazure
changed the title
|
I goofed and used the wrong commit tag, so this should be merged with the PR title instead of the commit message. Sorry. |
kaicataldo
approved these changes
Jun 9, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Adding "rcrelease" script to package.json.
What changes did you make? (Give an overview)
Adding "rcrelease" script to package.json, based on the "alpharelease" and "betarelease" scripts.
Is there anything you'd like reviewers to focus on?
Looking at the Makefile.js code, it looks like we should be able to support rc releases here by passing "rc" as a prerelease label to ReleaseOps from within the Makefile code.
Please take a look and let me know if I'm misreading the code.