Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Create docs landing page #10453

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Docs: Create docs landing page #10453

merged 1 commit into from
Jun 9, 2018

Conversation

platinumazure
Copy link
Member

The main purpose of this landing page is to allow users to view "https://eslint.org/docs", which currently is HTTP 404 on our site.

As a secondary benefit, this would also allow the landing page to be used as the launching point for Algolia's Docsearch crawler.

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Created a docs landing page, which links to the user guide, developer guide, and maintainer guide.

Is there anything you'd like reviewers to focus on?

Any improvements for the text I've written in each section?

The main purpose of this landing page is to allow users to view "https://eslint.org/docs", which currently is HTTP 404 on our site.

As a secondary benefit, this would also allow the landing page to be used as the launching point for Algolia's Docsearch crawler.
@platinumazure platinumazure added documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 7, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -0,0 +1,17 @@
# Documentation

Welcome to our documentation pages! What would you like to view?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding a short description about ESLint on the top?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aladdin-add Thanks for the suggestion! I feel that would be slightly redundant given the homepage and About pages. If you feel strongly, you or I could always add that in another PR. I'm going to go ahead and merge as is since this is easy to correct and won't impact users of ESLint (the library).

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 9, 2018
@platinumazure platinumazure merged commit d0aae3c into master Jun 9, 2018
@platinumazure platinumazure deleted the platinumazure-patch-2 branch June 9, 2018 14:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 8, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants