Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: rm unused argument #10400

Merged
merged 1 commit into from
May 27, 2018
Merged

Chore: rm unused argument #10400

merged 1 commit into from
May 27, 2018

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: rm unused argument

What changes did you make? (Give an overview)
the function defined in

function getConfigForStyleGuide(guide) {
, superfluous argument passed to function getConfigForStyleGuide.

Is there anything you'd like reviewers to focus on?
no~

@aladdin-add aladdin-add added the chore This change is not user-facing label May 27, 2018
@aladdin-add aladdin-add changed the title chore: rm unused argument Chore: rm unused argument May 27, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit b9b23a9 into master May 27, 2018
@aladdin-add aladdin-add deleted the Aladdin-ADD-patch-2 branch May 27, 2018 07:30
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 25, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants