Update: fix false negative in no-use-before-define (fixes #10227) #10396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
bug
There was a problem hiding this comment.
I wonder if we could decompose this PR: First PR would add tests which should pass with current behavior, second would change the logic and show that all tests still pass (as well as adding any new tests that didn't pass before the rule logic change). As it is, right now I can't quite tell what parts of this are new tests and what parts reflect actual changed behavior.
What do you think?
|
I reordered those tests. This PR fixes the former 5 test cases. Those were false negatives. The latter 4 test cases are not changed, but I thought those were lacking, about WithStatement. |
kaicataldo
approved these changes
Jun 9, 2018
|
Thanks for contributing! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #10227
What changes did you make? (Give an overview)
This PR does:
no-use-before-definerule.parserOptionsfrom the rule.Is there anything you'd like reviewers to focus on?
The tests for
CatchClauseandWithStatementwere lacking.Please check the added tests to make a consensus.