Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: polish for max-classes-per-file rule #10377

Merged
merged 1 commit into from
May 18, 2018
Merged

Docs: polish for max-classes-per-file rule #10377

merged 1 commit into from
May 18, 2018

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented May 18, 2018

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 18, 2018
@aladdin-add aladdin-add added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels May 18, 2018
platinumazure
platinumazure approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 18, 2018
@platinumazure platinumazure merged commit 074bc1c into eslint:master May 18, 2018
@g-plane g-plane deleted the docs-max-classes-per-file branch May 18, 2018 15:27
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 15, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@g-plane @platinumazure @aladdin-add