Fix: handle one-var with no semicolon (fixes #10330) #10371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#10330
What changes did you make? (Give an overview)
The fixer function for one-var can now handle semicolon-less style. The fixer checks if the previous token is actually a semicolon, and if not it just inserts the comma after the previous token instead of replacing it. Should be easy to understand from the edits.
Is there anything you'd like reviewers to focus on?
Based on the existing tests and my understanding of fixer functions, I only changed
to
instead of
Is this the right call?