Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prefer-const object destructuring false positive (fixes #9108) #10368

Merged
merged 1 commit into from
May 28, 2018
Merged

Fix: prefer-const object destructuring false positive (fixes #9108) #10368

merged 1 commit into from
May 28, 2018

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented May 17, 2018

close #9108

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#9108

What changes did you make? (Give an overview)
Allow:

(function ({ a }) {
  let b;
  ({ a, b } = obj);
})();

or

let a;
{
  let b;
  ({ a, b } = obj);
}

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 17, 2018
@aladdin-add aladdin-add added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 17, 2018
platinumazure
platinumazure approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like another set of eyes on this. Thanks for contributing!

btmills
btmills approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work on this, @g-plane!

lib/rules/prefer-const.js
@@ -290,7 +340,7 @@ module.exports = {
(varDeclParent.parent.type === "ForInStatement" || varDeclParent.parent.type === "ForOfStatement" || varDeclParent.declarations[0].init) &&

/*
* If options.destucturing is "all", then this warning will not occur unless
* If options.destructuring is "all", then this warning will not occur unless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄

@btmills btmills merged commit 240c1a4 into eslint:master May 28, 2018
@g-plane g-plane deleted the fix-prefer-const branch May 29, 2018 04:40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 26, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-const object destructuring false positive
4 participants
@g-plane @platinumazure @btmills @aladdin-add