Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule one-var fix to incorrect code when using semicolon-less style #10330

Closed
aladdin-add opened this issue May 10, 2018 · 1 comment
Closed
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@aladdin-add
Copy link
Member

aladdin-add commented May 10, 2018

Tell us about your environment

  • ESLint Version: master
  • Node Version: n
  • npm Version: n

What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:

{
  "one-var": 2
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

var i
var j

What did you expect to happen?
it should be fixed to

var i, j

What actually happened? Please include the actual, raw output from ESLint.

var ,
 j
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 10, 2018
@aladdin-add aladdin-add added bug ESLint is working incorrectly rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 10, 2018
@aladdin-add aladdin-add reopened this May 10, 2018
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 10, 2018
@malcolmsgroves
Copy link
Contributor

I'll work up a PR for this

malcolmsgroves added a commit to malcolmsgroves/eslint that referenced this issue May 17, 2018
malcolmsgroves added a commit to malcolmsgroves/eslint that referenced this issue May 17, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 21, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

2 participants