Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance 'no-tabs' rule: New option to only disallow non-indenting tabs #10256

Closed
fabio-silva opened this issue Apr 23, 2018 · 6 comments
Closed
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@fabio-silva
Copy link

fabio-silva commented Apr 23, 2018

What rule do you want to change?
no-tabs

Does this change cause the rule to produce more or fewer warnings?
Fewer, as indenting tabs will be allowed.

How will the change be implemented? (New option, new default behavior, etc.)?
New option.

Please provide some example code that this change will affect:

    var name =     'Foo'; //We should get a warning for the tab in between, not for the initial one

What does the rule currently do for this code?
A warning because there are tabs for indentation purposes (in the beginning) and for non-necessarily-indentation purposes (after the assignment)

What will the rule do after it's changed?
Allows indentation tabs using a proper option, but not non-indenting tabs. This could be something like allow-indenting.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 23, 2018
@platinumazure platinumazure self-assigned this Apr 23, 2018
@platinumazure
Copy link
Member

I'll champion this.

@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Apr 23, 2018
@platinumazure platinumazure changed the title Enhance 'no-tabs' rule: only disallow non-indenting tabs Enhance 'no-tabs' rule: New option to only disallow non-indenting tabs Apr 23, 2018
@platinumazure
Copy link
Member

@fabio-silva Thanks for creating this!

Hope it's okay that I tweaked the title a bit-- just wanted to avoid any team member seeing the title in the issue list and thinking this was about making a breaking change to the rule.

@fabio-silva
Copy link
Author

@platinumazure Yep, that's totally fine!

@not-an-aardvark
Copy link
Member

@eslint/eslint-team Anyone else in favor of this proposal? This issue only needs one more 👍 to accept it, otherwise it's probably time to close it.

@kaicataldo
Copy link
Member

This has now been accepted.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 23, 2018
@platinumazure
Copy link
Member

Working on this.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

4 participants