Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include #9908 in 4.x.x branch as bugfix #10244

Closed
betaorbust opened this issue Apr 20, 2018 · 2 comments
Closed

Include #9908 in 4.x.x branch as bugfix #10244

betaorbust opened this issue Apr 20, 2018 · 2 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion question This issue asks a question about ESLint

Comments

@betaorbust
Copy link
Contributor

Tell us about your environment: N/A

  • ESLint Version: 4.x.x
  • Node Version: N/A
  • npm Version: N/A

What parser (default, Babel-ESLint, etc.) are you using? N/A

Please show your full configuration: N/A

Issue

In #9890, we decided to go with a non-breaking change, to address an issue where data was required during rule testing with messageId. We went with non-breaking bugfix mentioned here but looks like it was mistagged as an enhancement in the actual PR #9908 and was put into the 5x line.

Proposed Solution
If there's another minor or patch release for the 4x line, can it also be applied there?

Thanks!
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 20, 2018
betaorbust added a commit to betaorbust/eslint-plugin-pocket-fluff that referenced this issue Apr 20, 2018
@betaorbust
Fix test bug.
b629f65 
eslint/eslint#10244
@not-an-aardvark
Copy link
Member

Hi again, thanks for creating an issue. I don't think we have any plans right now to do another v4.x release unless a critical bug is found (we're mainly working on v5.x right now), but if we do do another release I'll make sure #9908 is included in it.

@platinumazure platinumazure added question This issue asks a question about ESLint and removed triage An ESLint team member will look at this issue soon labels Apr 26, 2018
@not-an-aardvark not-an-aardvark mentioned this issue May 21, 2018
Closed
@platinumazure
Copy link
Member

Closing as the question has been answered. (We're hoping to release 5.0.0 this weekend.)

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 20, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion question This issue asks a question about ESLint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@platinumazure @betaorbust @not-an-aardvark