Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parser handling out of Linter? #10118

Closed
platinumazure opened this issue Mar 23, 2018 · 3 comments
Closed

Refactor parser handling out of Linter? #10118

platinumazure opened this issue Mar 23, 2018 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@platinumazure
Copy link
Member

I was thinking I'd like to add some debug logging around parser loading (i.e., similar to #10100 but for parsers) and I noticed that everything is still in Linter and we're working with a Map of parsers.

It'd be cool to refactor some of the parser loading/requiring out so we could have a new debug category, and also maybe test some of the parser logic outside of Linter and increase maintainability.

Thoughts? (Especially from @not-an-aardvark?)
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 23, 2018
@platinumazure platinumazure added core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Mar 23, 2018
@not-an-aardvark
Copy link
Member

In #9321 (comment), there was some agreement that having a separate module for loading parsers might add some unnecessary complexity, given that it's basically just a Map. That said, I have no objection to moving it if you think it would improve code quality and/or debugging experience.

@platinumazure
Copy link
Member Author

Thanks @not-an-aardvark, I forgot about that conversation.

I'll probably explore a POC and maybe push up a branch at some point, if it seems like this could be a low-complexity change.

@platinumazure
Copy link
Member Author

Closing for now as not a high priority. I can open a new issue later if I feel this needs to be looked at again.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 10, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@platinumazure @ilyavolodin @not-an-aardvark