Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no-invalid-regexp not understand variable for flags (fixes #10112) #10113

Merged
merged 1 commit into from Mar 22, 2018
Merged

Fix: no-invalid-regexp not understand variable for flags (fixes #10112) #10113

merged 1 commit into from Mar 22, 2018

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (template)

What changes did you make? (Give an overview)
flags was Initialized to "", but sometimes it could be null -- this might cause confusing.

Is there anything you'd like reviewers to focus on?
no. 😃

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 21, 2018
@aladdin-add aladdin-add added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 21, 2018
not-an-aardvark
not-an-aardvark approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added the patch candidate This issue may necessitate a patch release in the next few days label Mar 21, 2018
@not-an-aardvark not-an-aardvark merged commit 3ff5d11 into eslint:master Mar 22, 2018
This was referenced Mar 22, 2018
Closed
Merged
Merged
Open
Merged
Merged
Open
Closed
Closed
Open
Merged
Merged
Open
Closed
Merged
Merged
Closed
Closed
This was referenced Mar 22, 2018
Open
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Open
Closed
Merged
Open
Closed
Merged
Closed
Closed
Closed
Open
Merged
Merged
Merged
Merged
@aladdin-add aladdin-add deleted the issue10112 branch March 22, 2018 15:34
@renovate renovate bot mentioned this pull request Mar 23, 2018
Merged
@renovate renovate bot mentioned this pull request Apr 17, 2018
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 19, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@mysticatea mysticatea Awaiting requested review from mysticatea

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aladdin-add @platinumazure @ilyavolodin @not-an-aardvark