New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: make library files non-executable #10021
Conversation
e5ca74b
to
711a7b6
Compare
0644000
to
1006440
Compare
Could you explain what you mean by "marked as executable"? I'm pretty sure this is something I'm not familiar with, and since diff doesn't show anything, it's hard to review. |
All files have an "execute bit" stored as part of their metadata, which indicates whether the file can be executed on its own (e.g. as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Something to think about later: Is there an ESLint plugin or a more generalized pre-commit hook we could add to avoid this in future?
I don't know of any existing plugins. (I found these files with |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
lib/linter.js
andlib/rules/template-tag-spacing.js
are marked as executable but aren't actually valid executable files. This commit marks them as non-executable.Is there anything you'd like reviewers to focus on?
Nothing in particular