From f525bb86516310854fb52186ac402e35ece17ee9 Mon Sep 17 00:00:00 2001 From: "weiran.zsd" Date: Wed, 22 May 2019 04:07:49 +0800 Subject: [PATCH] fix: not report when the rule severity is 0 --- lib/linter.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/linter.js b/lib/linter.js index e79cdb5c9e33..44107923f8d5 100644 --- a/lib/linter.js +++ b/lib/linter.js @@ -297,10 +297,16 @@ function getDirectiveComments(filename, ast, ruleMapper) { if (parseResult.success) { Object.keys(parseResult.config).forEach(name => { + const rule = ruleMapper(name); const ruleValue = parseResult.config[name]; + if (rule === null) { + problems.push(createMissingProblem(name)); + return; + } + try { - validator.validateRuleOptions(ruleMapper(name), name, ruleValue); + validator.validateRuleOptions(rule, name, ruleValue); } catch (err) { problems.push({ ruleId: name, @@ -746,21 +752,15 @@ function runRules(sourceCode, configuredRules, ruleMapper, parserOptions, parser const severity = ConfigOps.getRuleSeverity(configuredRules[ruleId]); const rule = ruleMapper(ruleId); - /* - * report an linting error, if the rule: - * a. has been replaced by some other rules; - * b. has not been defined; - */ - if (!rule) { - lintingProblems.push(createMissingProblem(ruleId)); + if (severity === 0) { return; } - if (severity === 0) { + if (rule === null) { + lintingProblems.push(createMissingProblem(ruleId)); return; } - const messageIds = rule.meta && rule.meta.messages; let reportTranslator = null; const ruleContext = Object.freeze(