From d08f1ecac7910e165efcd227164468ec9be31146 Mon Sep 17 00:00:00 2001 From: Brandon Mills Date: Sun, 21 Nov 2021 12:30:41 -0500 Subject: [PATCH] chore: Make fixture test assertions more explicit I need to add another formatter to this directory that will shift all of these results, so I'm making these assertions more explicit so it's obvious why a seemingly-unrelated change will cause these to fail. --- tests/lib/cli-engine/cli-engine.js | 21 +++++++++++++++------ tests/lib/eslint/eslint.js | 12 ++++++++---- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/tests/lib/cli-engine/cli-engine.js b/tests/lib/cli-engine/cli-engine.js index 31f59bf51b4..f29572ad15f 100644 --- a/tests/lib/cli-engine/cli-engine.js +++ b/tests/lib/cli-engine/cli-engine.js @@ -1158,28 +1158,32 @@ describe("CLIEngine", () => { configFile: getFixturePath("configurations", "semi-error.json") }); - const report = engine.executeOnFiles([getFixturePath("formatters")]); + const fixturePath = getFixturePath("formatters"); + const report = engine.executeOnFiles([fixturePath]); - assert.strictEqual(report.results.length, 3); assert.strictEqual(report.errorCount, 0); assert.strictEqual(report.warningCount, 0); assert.strictEqual(report.fixableErrorCount, 0); assert.strictEqual(report.fixableWarningCount, 0); - assert.strictEqual(report.results[0].messages.length, 0); - assert.strictEqual(report.results[1].messages.length, 0); - assert.strictEqual(report.results[2].messages.length, 0); + assert.strictEqual(report.results.length, 3); + assert.strictEqual(path.relative(fixturePath, report.results[0].filePath), "broken.js"); assert.strictEqual(report.results[0].errorCount, 0); assert.strictEqual(report.results[0].warningCount, 0); assert.strictEqual(report.results[0].fixableErrorCount, 0); assert.strictEqual(report.results[0].fixableWarningCount, 0); + assert.strictEqual(report.results[0].messages.length, 0); + assert.strictEqual(path.relative(fixturePath, report.results[1].filePath), "simple.js"); assert.strictEqual(report.results[1].errorCount, 0); assert.strictEqual(report.results[1].warningCount, 0); assert.strictEqual(report.results[1].fixableErrorCount, 0); assert.strictEqual(report.results[1].fixableWarningCount, 0); + assert.strictEqual(report.results[1].messages.length, 0); + assert.strictEqual(path.relative(fixturePath, report.results[2].filePath), path.join("test", "simple.js")); assert.strictEqual(report.results[2].errorCount, 0); assert.strictEqual(report.results[2].warningCount, 0); assert.strictEqual(report.results[2].fixableErrorCount, 0); assert.strictEqual(report.results[2].fixableWarningCount, 0); + assert.strictEqual(report.results[2].messages.length, 0); }); @@ -1190,20 +1194,25 @@ describe("CLIEngine", () => { configFile: getFixturePath("configurations", "single-quotes-error.json") }); - const report = engine.executeOnFiles([getFixturePath("formatters")]); + const fixturePath = getFixturePath("formatters"); + const report = engine.executeOnFiles([fixturePath]); assert.strictEqual(report.errorCount, 6); assert.strictEqual(report.warningCount, 0); assert.strictEqual(report.fixableErrorCount, 6); assert.strictEqual(report.fixableWarningCount, 0); + assert.strictEqual(report.results.length, 3); + assert.strictEqual(path.relative(fixturePath, report.results[0].filePath), "broken.js"); assert.strictEqual(report.results[0].errorCount, 0); assert.strictEqual(report.results[0].warningCount, 0); assert.strictEqual(report.results[0].fixableErrorCount, 0); assert.strictEqual(report.results[0].fixableWarningCount, 0); + assert.strictEqual(path.relative(fixturePath, report.results[1].filePath), "simple.js"); assert.strictEqual(report.results[1].errorCount, 3); assert.strictEqual(report.results[1].warningCount, 0); assert.strictEqual(report.results[1].fixableErrorCount, 3); assert.strictEqual(report.results[1].fixableWarningCount, 0); + assert.strictEqual(path.relative(fixturePath, report.results[2].filePath), path.join("test", "simple.js")); assert.strictEqual(report.results[2].errorCount, 3); assert.strictEqual(report.results[2].warningCount, 0); assert.strictEqual(report.results[2].fixableErrorCount, 3); diff --git a/tests/lib/eslint/eslint.js b/tests/lib/eslint/eslint.js index 8c2b4c656fa..132b91a8ef1 100644 --- a/tests/lib/eslint/eslint.js +++ b/tests/lib/eslint/eslint.js @@ -1210,24 +1210,28 @@ describe("ESLint", () => { cwd: path.join(fixtureDir, ".."), overrideConfigFile: getFixturePath("configurations", "semi-error.json") }); - const results = await eslint.lintFiles([getFixturePath("formatters")]); + const fixturePath = getFixturePath("formatters"); + const results = await eslint.lintFiles([fixturePath]); assert.strictEqual(results.length, 3); - assert.strictEqual(results[0].messages.length, 0); - assert.strictEqual(results[1].messages.length, 0); - assert.strictEqual(results[2].messages.length, 0); + assert.strictEqual(path.relative(fixturePath, results[0].filePath), "broken.js"); assert.strictEqual(results[0].errorCount, 0); assert.strictEqual(results[0].warningCount, 0); assert.strictEqual(results[0].fixableErrorCount, 0); assert.strictEqual(results[0].fixableWarningCount, 0); + assert.strictEqual(results[0].messages.length, 0); + assert.strictEqual(path.relative(fixturePath, results[1].filePath), "simple.js"); assert.strictEqual(results[1].errorCount, 0); assert.strictEqual(results[1].warningCount, 0); assert.strictEqual(results[1].fixableErrorCount, 0); assert.strictEqual(results[1].fixableWarningCount, 0); + assert.strictEqual(results[1].messages.length, 0); + assert.strictEqual(path.relative(fixturePath, results[2].filePath), path.join("test", "simple.js")); assert.strictEqual(results[2].errorCount, 0); assert.strictEqual(results[2].warningCount, 0); assert.strictEqual(results[2].fixableErrorCount, 0); assert.strictEqual(results[2].fixableWarningCount, 0); + assert.strictEqual(results[2].messages.length, 0); }); it("should process when file is given by not specifying extensions", async () => {