From 978fcc5e30b39eb96760b3f9ecd9c62b427688a7 Mon Sep 17 00:00:00 2001
From: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
Date: Tue, 28 May 2019 20:04:54 -0400
Subject: [PATCH] Chore: removes unnecessary assignment in loop

also reduces cyclomatic complexity with a slight reconfiguring of some conditions
---
 lib/linter/node-event-generator.js | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/linter/node-event-generator.js b/lib/linter/node-event-generator.js
index cea89262e5cf..73acb058c93d 100644
--- a/lib/linter/node-event-generator.js
+++ b/lib/linter/node-event-generator.js
@@ -221,17 +221,23 @@ class NodeEventGenerator {
             const selector = parseSelector(rawSelector);
 
             if (selector.listenerTypes) {
-                selector.listenerTypes.forEach(nodeType => {
-                    const typeMap = selector.isExit ? this.exitSelectorsByNodeType : this.enterSelectorsByNodeType;
+                const typeMap = selector.isExit ? this.exitSelectorsByNodeType : this.enterSelectorsByNodeType;
 
+                selector.listenerTypes.forEach(nodeType => {
                     if (!typeMap.has(nodeType)) {
                         typeMap.set(nodeType, []);
                     }
                     typeMap.get(nodeType).push(selector);
                 });
-            } else {
-                (selector.isExit ? this.anyTypeExitSelectors : this.anyTypeEnterSelectors).push(selector);
+                return;
             }
+            
+            if (selector.isExit) {
+                this.anyTypeExitSelectors.push(selector);
+                return;
+            }
+
+            this.anyTypeEnterSelectors.push(selector);
         });
 
         this.anyTypeEnterSelectors.sort(compareSpecificity);