From 7e80da5ac8c9c1bd50ec5516a359c55ac6e671d7 Mon Sep 17 00:00:00 2001 From: "Nicholas C. Zakas" Date: Mon, 5 Nov 2018 08:45:33 -0800 Subject: [PATCH] Final update of rule types --- lib/rules/no-buffer-constructor.js | 2 +- lib/rules/no-use-before-define.js | 2 +- lib/rules/valid-jsdoc.js | 2 +- tools/rule-types.json | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/rules/no-buffer-constructor.js b/lib/rules/no-buffer-constructor.js index a1f2a1d1ad7..bf4c8891ad1 100644 --- a/lib/rules/no-buffer-constructor.js +++ b/lib/rules/no-buffer-constructor.js @@ -10,7 +10,7 @@ module.exports = { meta: { - type: "suggestion", + type: "problem", docs: { description: "disallow use of the `Buffer()` constructor", diff --git a/lib/rules/no-use-before-define.js b/lib/rules/no-use-before-define.js index 6f0b66bdb52..500cd3a4103 100644 --- a/lib/rules/no-use-before-define.js +++ b/lib/rules/no-use-before-define.js @@ -136,7 +136,7 @@ function isInInitializer(variable, reference) { module.exports = { meta: { - type: "suggestion", + type: "problem", docs: { description: "disallow the use of variables before they are defined", diff --git a/lib/rules/valid-jsdoc.js b/lib/rules/valid-jsdoc.js index c7b96af5c05..b434491bfad 100644 --- a/lib/rules/valid-jsdoc.js +++ b/lib/rules/valid-jsdoc.js @@ -16,7 +16,7 @@ const doctrine = require("doctrine"); module.exports = { meta: { - type: "problem", + type: "suggestion", docs: { description: "enforce valid JSDoc comments", diff --git a/tools/rule-types.json b/tools/rule-types.json index 5320ad7f7bc..40010c8969d 100644 --- a/tools/rule-types.json +++ b/tools/rule-types.json @@ -75,7 +75,7 @@ "no-async-promise-executor": "problem", "no-await-in-loop": "problem", "no-bitwise": "suggestion", - "no-buffer-constructor": "suggestion", + "no-buffer-constructor": "problem", "no-caller": "suggestion", "no-case-declarations": "suggestion", "no-catch-shadow": "suggestion", @@ -194,7 +194,7 @@ "no-unused-expressions": "suggestion", "no-unused-labels": "suggestion", "no-unused-vars": "problem", - "no-use-before-define": "suggestion", + "no-use-before-define": "problem", "no-useless-call": "suggestion", "no-useless-computed-key": "suggestion", "no-useless-concat": "suggestion", @@ -256,7 +256,7 @@ "template-tag-spacing": "layout", "unicode-bom": "layout", "use-isnan": "problem", - "valid-jsdoc": "problem", + "valid-jsdoc": "suggestion", "valid-typeof": "problem", "vars-on-top": "suggestion", "wrap-iife": "layout",