From 555b4dfdefe056535b4b1e3909a4b20ee634ecdd Mon Sep 17 00:00:00 2001 From: Che Fisher Date: Sat, 24 Nov 2018 18:11:25 +0100 Subject: [PATCH] fix faulty tests The original tests were expecting a space where they should have been rejecting one. Remember to invert: "spaces are never an error except inside parentheses" OR "spaces are always an error when inside parentheses" --- tests/lib/rules/space-in-parens.js | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/lib/rules/space-in-parens.js b/tests/lib/rules/space-in-parens.js index 6e66a8fbd34b..0cd775fb4073 100644 --- a/tests/lib/rules/space-in-parens.js +++ b/tests/lib/rules/space-in-parens.js @@ -35,6 +35,7 @@ ruleTester.run("space-in-parens", rule, { { code: "var x = ( 1 + 2 ) * 3", options: ["always"] }, { code: "var x = 'foo(bar)'", options: ["always"] }, { code: "var x = 'bar( baz )'", options: ["always"] }, + { code: "var foo = (1 / (1 + 2))", options: ["never", { exceptions: ["()"] }] }, { code: "var foo = `(bar)`;", options: ["always"], parserOptions: { ecmaVersion: 6 } }, { code: "var foo = `(bar ${baz})`;", options: ["always"], parserOptions: { ecmaVersion: 6 } }, { code: "var foo = `(bar ${( 1 + 2 )})`;", options: ["always"], parserOptions: { ecmaVersion: 6 } }, @@ -84,7 +85,7 @@ ruleTester.run("space-in-parens", rule, { { code: "foo( [ 1, 2 ], 1)", options: ["never", { exceptions: ["[]"] }] }, { code: "foo( [\n1,\n2\n] )", options: ["never", { exceptions: ["[]"] }] }, - { code: "foo(( 1 + 2 ))", options: ["always", { exceptions: ["()"] }] }, + { code: "foo((1 + 2))", options: ["always", { exceptions: ["()"] }] }, { code: "foo( ( 1 + 2 ) )", options: ["always", { exceptions: ["{}"] }] }, { code: "foo( 1 / ( 1 + 2 ))", options: ["always", { exceptions: ["()"] }] }, { code: "foo(( 1 + 2 ) / 1 )", options: ["always", { exceptions: ["()"] }] }, @@ -363,13 +364,13 @@ ruleTester.run("space-in-parens", rule, { }, { code: "( (1 + 2))", - output: "( (1 + 2) )", + output: "((1 + 2))", options: ["never", { exceptions: ["()"] }], - errors: [MISSING_SPACE_ERROR] + errors: [REJECTED_SPACE_ERROR] }, { - code: "(( 1 + 2 ) )", - output: "(( 1 + 2 ))", + code: "(foo() )", + output: "(foo())", options: ["always", { exceptions: ["()"] }], errors: [REJECTED_SPACE_ERROR] }, @@ -386,10 +387,10 @@ ruleTester.run("space-in-parens", rule, { errors: [REJECTED_SPACE_ERROR] }, { - code: "var result = (1 / (1 + 2)) + 3", - output: "var result = (1 / (1 + 2) ) + 3", + code: "var result = ( 1 / (1 + 2) ) + 3", + output: "var result = (1 / (1 + 2)) + 3", options: ["never", { exceptions: ["()"] }], - errors: [MISSING_SPACE_ERROR] + errors: [REJECTED_SPACE_ERROR, REJECTED_SPACE_ERROR] }, { code: "var result = ( 1 / ( 1 + 2)) + 3",