From 13bcf3ca531d699ee68567154e720377219773d0 Mon Sep 17 00:00:00 2001 From: Kevin Partington Date: Fri, 19 Jan 2018 18:19:11 -0600 Subject: [PATCH] Fix: Removing curly quotes in no-eq-null report message (#9852) --- lib/rules/no-eq-null.js | 2 +- tests/lib/rules/no-eq-null.js | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/rules/no-eq-null.js b/lib/rules/no-eq-null.js index befb9d46f09..22dbd49d421 100644 --- a/lib/rules/no-eq-null.js +++ b/lib/rules/no-eq-null.js @@ -31,7 +31,7 @@ module.exports = { if (node.right.type === "Literal" && node.right.raw === "null" && badOperator || node.left.type === "Literal" && node.left.raw === "null" && badOperator) { - context.report({ node, message: "Use ‘===’ to compare with ‘null’." }); + context.report({ node, message: "Use '===' to compare with null." }); } } }; diff --git a/tests/lib/rules/no-eq-null.js b/tests/lib/rules/no-eq-null.js index 7fdb1e44084..23d992dc58f 100644 --- a/tests/lib/rules/no-eq-null.js +++ b/tests/lib/rules/no-eq-null.js @@ -18,14 +18,16 @@ const rule = require("../../../lib/rules/no-eq-null"), const ruleTester = new RuleTester(); +const MESSAGE = "Use '===' to compare with null."; + ruleTester.run("no-eq-null", rule, { valid: [ "if (x === null) { }", "if (null === f()) { }" ], invalid: [ - { code: "if (x == null) { }", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] }, - { code: "if (x != null) { }", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] }, - { code: "do {} while (null == x)", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] } + { code: "if (x == null) { }", errors: [{ message: MESSAGE, type: "BinaryExpression" }] }, + { code: "if (x != null) { }", errors: [{ message: MESSAGE, type: "BinaryExpression" }] }, + { code: "do {} while (null == x)", errors: [{ message: MESSAGE, type: "BinaryExpression" }] } ] });