From 9fb0f7040759ea23538997648f2d2d53e7c9db8a Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Tue, 14 Sep 2021 15:53:07 +0200 Subject: [PATCH 1/3] Chore: fix bug report template (#15061) --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 4102d50a0882..8c477f442400 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -18,7 +18,7 @@ body: npm version: Local ESLint version: Global ESLint version: - Operating System: + Operating System: validations: required: true - type: dropdown @@ -43,6 +43,7 @@ body: value: |
Configuration + ``` ``` @@ -51,7 +52,6 @@ body: ```js ``` - render: markdown validations: required: true - type: textarea From a744dfa1f077afe406014f84135f8d26e9a12a94 Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Tue, 14 Sep 2021 20:16:52 -0400 Subject: [PATCH 2/3] Docs: Update CLA info (#15058) This doc change removes a reference to the decommissioned JSF CLA, and replaces it with the new OpenJS Foundation CLA infra. Signed-off-by: Brian Warner --- docs/developer-guide/contributing/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developer-guide/contributing/README.md b/docs/developer-guide/contributing/README.md index e341083febce..25a889466e5b 100644 --- a/docs/developer-guide/contributing/README.md +++ b/docs/developer-guide/contributing/README.md @@ -10,7 +10,7 @@ ESLint welcomes contributions from everyone and adheres to the [OpenJS Foundatio ## [Signing the CLA](https://openjsf.org/about/the-openjs-foundation-cla/) -In order to submit code or documentation to an ESLint project, you will need to electronically sign our [Contributor License Agreement](https://cla.js.foundation/eslint/eslint). The CLA is you giving us permission to use your contribution. +In order to submit code or documentation to an ESLint project, you will need to electronically sign our [Contributor License Agreement](https://github.com/openjs-foundation/easycla). The CLA is the commonly used Apache-style template, and is you giving us permission to use your contribution. You only need to sign the CLA once for any OpenJS Foundation projects that use EasyCLA. ## [Bug Reporting](reporting-bugs) From 47be8003d700bc0606495ae42610eaba94e639c5 Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Thu, 16 Sep 2021 20:49:34 +0200 Subject: [PATCH 3/3] Chore: test Property > .key with { a = 1 } pattern (fixes #14799) (#15072) --- tests/lib/linter/node-event-generator.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/lib/linter/node-event-generator.js b/tests/lib/linter/node-event-generator.js index 8cd1427134f4..afedc9d0171b 100644 --- a/tests/lib/linter/node-event-generator.js +++ b/tests/lib/linter/node-event-generator.js @@ -314,6 +314,15 @@ describe("NodeEventGenerator", () => { ["[name.length=3]:exit", ast.body[1].expression] ] ); + + // https://github.com/eslint/eslint/issues/14799 + assertEmissions( + "const {a = 1} = b;", + ["Property > .key"], + ast => [ + ["Property > .key", ast.body[0].declarations[0].id.properties[0].key] + ] + ); }); describe("traversing the entire non-standard AST", () => {