/
no-dupe-else-if.js
172 lines (154 loc) · 6.13 KB
/
no-dupe-else-if.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
/**
* @fileoverview Tests for the no-dupe-else-if rule
* @author Milos Djermanovic
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/no-dupe-else-if");
const { RuleTester } = require("../../../lib/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester();
ruleTester.run("no-dupe-else-if", rule, {
valid: [
// different test conditions
"if (a) {} else if (b) {}",
"if (a); else if (b); else if (c);",
"if (true) {} else if (false) {} else {}",
"if (1) {} else if (2) {}",
"if (f) {} else if (f()) {}",
"if (f(a)) {} else if (g(a)) {}",
"if (f(a)) {} else if (f(b)) {}",
"if (a === 1) {} else if (a === 2) {}",
"if (a === 1) {} else if (b === 1) {}",
// not an if-else-if chain
"if (a) {}",
"if (a);",
"if (a) {} else {}",
"if (a) if (a) {}",
"if (a) if (a);",
"if (a) { if (a) {} }",
"if (a) {} else { if (a) {} }",
"if (a) {} if (a) {}",
"if (a); if (a);",
"while (a) if (a);",
"if (a); else a ? a : a;",
// not same conditions in the chain
"if (a) { if (b) {} } else if (b) {}",
"if (a) if (b); else if (a);",
// not equal tokens
"if (a) {} else if (!!a) {}",
"if (a === 1) {} else if (a === (1)) {}"
],
invalid: [
// basic tests
{
code: "if (a) {} else if (a) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 20 }]
},
{
code: "if (a); else if (a);",
errors: [{ messageId: "unexpected", type: "Identifier", column: 18 }]
},
{
code: "if (a) {} else if (a) {} else {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 20 }]
},
{
code: "if (a) {} else if (b) {} else if (a) {} else if (c) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 35 }]
},
{
code: "if (a) {} else if (b) {} else if (a) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 35 }]
},
{
code: "if (a) {} else if (b) {} else if (c) {} else if (a) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 50 }]
},
{
code: "if (a) {} else if (b) {} else if (b) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 35 }]
},
{
code: "if (a) {} else if (b) {} else if (b) {} else {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 35 }]
},
{
code: "if (a) {} else if (b) {} else if (c) {} else if (b) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 50 }]
},
{
code: "if (a); else if (b); else if (c); else if (b); else if (d); else;",
errors: [{ messageId: "unexpected", type: "Identifier", column: 44 }]
},
{
code: "if (a); else if (b); else if (c); else if (d); else if (b); else if (e);",
errors: [{ messageId: "unexpected", type: "Identifier", column: 57 }]
},
// multiple duplicates of the same condition
{
code: "if (a) {} else if (a) {} else if (a) {}",
errors: [
{ messageId: "unexpected", type: "Identifier", column: 20 },
{ messageId: "unexpected", type: "Identifier", column: 35 }
]
},
// multiple duplicates of different conditions
{
code: "if (a) {} else if (b) {} else if (a) {} else if (b) {} else if (a) {}",
errors: [
{ messageId: "unexpected", type: "Identifier", column: 35 },
{ messageId: "unexpected", type: "Identifier", column: 50 },
{ messageId: "unexpected", type: "Identifier", column: 65 }
]
},
// inner if statements do not affect chain
{
code: "if (a) { if (b) {} } else if (a) {}",
errors: [{ messageId: "unexpected", type: "Identifier", column: 31 }]
},
// various kinds of test conditions
{
code: "if (a === 1) {} else if (a === 1) {}",
errors: [{ messageId: "unexpected", type: "BinaryExpression", column: 26 }]
},
{
code: "if (1 < a) {} else if (1 < a) {}",
errors: [{ messageId: "unexpected", type: "BinaryExpression", column: 24 }]
},
{
code: "if (true) {} else if (true) {}",
errors: [{ messageId: "unexpected", type: "Literal", column: 23 }]
},
{
code: "if (a && b) {} else if (a && b) {}",
errors: [{ messageId: "unexpected", type: "LogicalExpression", column: 25 }]
},
{
code: "if (a && b || c) {} else if (a && b || c) {}",
errors: [{ messageId: "unexpected", type: "LogicalExpression", column: 31 }]
},
{
code: "if (f(a)) {} else if (f(a)) {}",
errors: [{ messageId: "unexpected", type: "CallExpression", column: 23 }]
},
// spaces and comments do not affect comparison
{
code: "if (a === 1) {} else if (a===1) {}",
errors: [{ messageId: "unexpected", type: "BinaryExpression", column: 26 }]
},
{
code: "if (a === 1) {} else if (a === /* comment */ 1) {}",
errors: [{ messageId: "unexpected", type: "BinaryExpression", column: 26 }]
},
// extra parens around the whole test condition do not affect comparison
{
code: "if (a === 1) {} else if ((a === 1)) {}",
errors: [{ messageId: "unexpected", type: "BinaryExpression", column: 27 }]
}
]
});