Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild and publish playground after releases #233

Closed
mdjermanovic opened this issue Jun 17, 2022 · 6 comments · Fixed by eslint/eslint#16034
Closed

Rebuild and publish playground after releases #233

mdjermanovic opened this issue Jun 17, 2022 · 6 comments · Fixed by eslint/eslint#16034
Labels
Projects

Comments

@mdjermanovic
Copy link
Member

Ideally, after each ESLint release the playground would be automatically re-built with the new version of ESLint and published.

This looks like a good case for the use of Netlify build hooks, assuming that the build hooks trigger all of build -> deploy -> publish.

@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Jun 17, 2022
@nzakas
Copy link
Member

nzakas commented Jun 18, 2022

Build hooks only rebuild what’s in the repo already. We would also need a way to update the ESLint version in package.json. I was going to check and see if there was a way to trigger a GitHub workflow based on a release in another repo. Worst case, we could build this into the bot.

@mdjermanovic
Copy link
Member Author

Version in the root is used to lint the playground repo.

The version we're building the playground from is in src/playground/node_modules/eslint. It's always installed by the build script as "eslint": "latest". A full rebuild should do the work without the need to update anything in the repo. A problem could be only Netlify's change detection if it applies when the build is triggered by a hook.

@mdjermanovic
Copy link
Member Author

I've just tried with a build hook and it has successfully published playground with ESLint v8.18.0

@nzakas
Copy link
Member

nzakas commented Jun 20, 2022

Oh nice! 🎉 So I guess all we need is a workflow to trigger the build hook on release?

@mdjermanovic
Copy link
Member Author

all we need is a workflow to trigger the build hook on release?

Yes, that should work well in this case

@mdjermanovic
Copy link
Member Author

eslint/eslint#16034

Triage automation moved this from Needs Triage to Complete Jun 21, 2022
nzakas pushed a commit to eslint/eslint that referenced this issue Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

2 participants