Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle "revert" commits in blogposts #18

Open
ilyavolodin opened this issue Sep 18, 2017 · 2 comments
Open

Handle "revert" commits in blogposts #18

ilyavolodin opened this issue Sep 18, 2017 · 2 comments
Labels
bug

Comments

@ilyavolodin
Copy link
Member

Currently, we remove "Revert" commits from the blog posts, this unit tests seems to indicated that's a correct behavior:

eslint-release/tests/lib/release-ops.js

Line 147 in 6e4bd2d

"* 1234abc Revert \"New: From a previous release (fixes #1234)\" (Foo Bar)",

If revert happens a different release then original commit, we should probably show it in blog post.
@btmills
Copy link
Member

btmills commented Sep 18, 2017 •
edited

we should probably show it in blog post

While excluding it from version calculation, yes?

@ilyavolodin
Copy link
Member Author

I think so. I don't think we should ever include "revert" into version calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilyavolodin @btmills