Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add node v18 #205

Merged
merged 2 commits into from Jun 27, 2022
Merged

chore: add node v18 #205

merged 2 commits into from Jun 27, 2022

Conversation

amareshsm
Copy link
Member

Description :

Add node v18

@btmills
Copy link
Member

btmills commented Jun 9, 2022

Just approved the CI run so you can see the error logs in Node 18. Manual approval shouldn't be necessary anymore once #203 is merged and you have a commit in the repository.

@btmills
Copy link
Member

btmills commented Jun 20, 2022

This and your other PR appear to be failing due to behavior changes in new npm versions that were released since the previous merges to main. Nothing about your change caused these failures. I've submitted #206 to fix the changes on main. Once that's in, I bet rebasing both of your branches will let them pass 👍

@btmills
Copy link
Member

btmills commented Jun 23, 2022

Closing and reopening to get CI to pass now that #206 fixes it. This will likely have merge conflicts and need to be rebased on #203 once that PR is merged.

@btmills btmills closed this Jun 23, 2022
@btmills btmills reopened this Jun 23, 2022
@snitin315 snitin315 marked this pull request as ready for review June 23, 2022 11:50
snitin315
snitin315 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI is also working fine. Should be merged after #203

@nzakas
Copy link
Member

nzakas commented Jun 25, 2022

I fixed the merge conflicts. Please review.

btmills
btmills approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@btmills btmills merged commit 558ae3c into eslint:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
chore triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amareshsm @btmills @nzakas @snitin315