Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use actions/setup-node@v2 in CI #192

Merged
merged 1 commit into from Sep 29, 2021
Merged

Chore: use actions/setup-node@v2 in CI #192

merged 1 commit into from Sep 29, 2021

Conversation

snitin315
Copy link
Contributor

CI-related change.

updated setup-node action to v2 for CI node workflow.

https://github.com/marketplace/actions/setup-node-js-environment

btmills
btmills approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks! LGTM as-is, but since this version supports caching, do you have any interest in enabling that too?

@snitin315
Copy link
Contributor Author

I think we need a package-lock.json to enable caching, and the repository doesn't have one. There was a similar attempt in eslint repo for this in eslint/eslint#14843

@btmills
Copy link
Member

btmills commented Sep 29, 2021

I think we need a package-lock.json to enable caching, and the repository doesn't have one.

Ah, never mind then.

@btmills btmills merged commit ffdb245 into main Sep 29, 2021
@btmills btmills deleted the chore/update-setup-node branch September 29, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snitin315 @btmills