New: Add recommended config (fixes #151) #153
Merged
+87
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmills
changed the title
Merged
platinumazure
approved these changes
Aug 1, 2020
kaicataldo
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should
plugin:markdown/recommendedenable the processor on just.mdfiles or also.mkdn,.mdown, and.markdown(the same file extensions as v1)? I went with just.mdsince overriding to add the other extensions is straightforward, but I could be convinced to include the other three.Is test coverage adequate? I My thinking was that asserting "it works" is sufficient to say the recommended config is being loaded, and the rest of the plugin tests can handle the details.