Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Build: build step takes a long time, causing Netlify deploys to fail #679

Closed
kaicataldo opened this issue Jan 8, 2020 · 4 comments
Closed
Labels
infrastructure Relates to the tools used to develop the website

Comments

@kaicataldo
Copy link
Member

kaicataldo commented Jan 8, 2020

Our Netlify deploys are currently failing, and I believe it's due to the fact that we're now bundling ESLint in our build step, causing the Netlify build to time out. The bundling takes a long time locally as well (I think this is due to babel-loader having to be run on src/js/demo/node_modules/*). By adding sleep 500 to the build step, I was able to see the full logs in the Netlify deploy console, and it looks like it's succeeding.

I've contacted Netlify support to see if there's a better way we can increase the timeout duration as a short term fix. Long term, we've discussed moving the website release scripts into this repo in the past, and doing so could allow us to build ESLint as part of the release script and commit it into this repo for reuse. This potentially makes the bundle bigger in the future (when shipping ESM packages is more common and Webpack can do more effective tree-shaking), but I don't think has much effect now.

I'm not seeing the bundling step take so long after updating dependencies, but I'm still seeing failures. Will keep digging.

@kaicataldo kaicataldo added the infrastructure Relates to the tools used to develop the website label Jan 8, 2020
@kaicataldo
Copy link
Member Author

kaicataldo commented Jan 8, 2020

As an interim solution, I have temporarily changed the Netlify deploy script from npm run build to npm run build:eleventy && npm run build:less && npm run build:webpack && sleep 100, which prevents it from timing out.

@kaicataldo kaicataldo changed the title Build: bundling step takes a long time, causing Netlify deploys to fail Build: build step takes a long time, causing Netlify deploys to fail Jan 8, 2020
@kaicataldo
Copy link
Member Author

Crossing my fingers that this fixes it. Both the preview and production deploys passed on the first run, and deploy time went from ~12 minutes to ~2:30.

@kaicataldo
Copy link
Member Author

I think we're back in business. All 4 deploys since the PR linked above have passed on the first try in around ~2:30. 🤞

@kaicataldo
Copy link
Member Author

kaicataldo commented Feb 5, 2020

Since #690 was merged, builds seem to have stabilized. Closing this but will be keeping an eye on things.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infrastructure Relates to the tools used to develop the website
Projects
None yet
Development

No branches or pull requests

1 participant