Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

ESLint Demo doesn't show red-line on the error locations #618

Open
mysticatea opened this issue Aug 31, 2019 · 3 comments
Open

ESLint Demo doesn't show red-line on the error locations #618

mysticatea opened this issue Aug 31, 2019 · 3 comments
Labels
bug The site is working incorrectly

Comments

@mysticatea
Copy link
Member

image

I expected the editor to show red wave lines on the error locations and show popups when I hovered the mouse pointer.

@mysticatea mysticatea added the bug The site is working incorrectly label Aug 31, 2019
@kaicataldo
Copy link
Member

Huh, the red wavy lines were working when I switched out the underlying code editor (though maybe they don't show up when it's only highlighting one character?). What browser are you seeing this in?

This is what I see (in latest Firefox):
Screen Shot 2019-09-04 at 5 01 44 PM
Screen Shot 2019-09-04 at 5 01 56 PM

@mdjermanovic
Copy link
Member

Does this particular example look a little better now? Seems that the red lines don't want to go much under the parens in Chrome, but at least something is visible now. It looks ok in Firefox.

This was changed in eslint/eslint#12302, it happens when a rule reports only loc.start.

There is an issue eslint/eslint#12334 to fix this in other rules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug The site is working incorrectly
Projects
None yet
Development

No branches or pull requests

3 participants