indent does not work well with eslint-plugin-mdx

[JounQin]

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Describe the bug

From antfu/eslint-config#347 and https://github.com/antfu/eslint-config/pull/353/files#r1420692632

Reproduction

https://github.com/antfu/eslint-config

Contributes

• I am willing to submit a PR to fix this issue
• I am willing to submit a PR with failing tests

[antfu]

Trying to dig a little bit, it seems that the indent rules reads all tokens:

eslint-stylistic/packages/eslint-plugin-js/rules/indent/indent.ts

Lines 182 to 186 in 82efdd5

	const tokens = sourceCode.tokensAndComments
	for (let i = 0; i < tokens.length; i++) {
	const token = tokens[i]

While eslint-mdx produces program.body that only contains JS statements, some markdown notes are presented in the tokens:

I wonder if those tokens are used somewhere, is it possible to filter them out, or provide an options to omit them?

[JounQin]

I wonder if those tokens are used somewhere, is it possible to filter them out, or provide an options to omit them?

The tokens are there because they should? Maybe indent is not meant to be used on .mdx, so then feel free to close. If it wants to support other files, then that's indent rule's mission.

[antfu]

It basically means that the source.ast.body and source.ast.tokens are misaligned in the past produced to by eslint-mdx. If eslint-mdx trying to produce an AST compatible with the ESTree that can be handled by other rules, I believe this is not expected.

And for the record, this is how indent rule works in ESLint core. We haven't changed anything about it.

[JounQin]

And for the record, this is how indent rule works in ESLint core. We haven't changed anything about it.

Yes, because it's not meant to be run on .mdx files.

[antfu]

Well, if you say so, good luck then.

[JounQin]

I'm also trying to add more ESTree compatible MDX related node types start from mdx-js/eslint-mdx#489

[JounQin]

I'm also trying to add more ESTree compatible MDX related node types start from mdx-js/eslint-mdx#489

@antfu Can you reopen this issue and assign it me?

[antfu]

What's your plan for fixing it? I would think it's better to fix it on MDX side, unless it's very easy to fix here.

[JounQin]

I'm planning to fix it it eslint-mdx.

---

Besides, I'm one of the maintainer of eslint-config-prettier now, and I want to support @eslint-stylistic in the long term, see also prettier/eslint-config-prettier#276 (comment), it would be nice if I can join this organization, and also so that I can transfer this issue to https://github.com/mdx-js/eslint-mdx instead.

[antfu]

Not that I do not trust you, but I don't think it's a good reason to join an org just to transfer away an issue. Why not just create another issue on mdx and link to this one?

[JounQin]

@antfu

Why not just create another issue on mdx and link to this one?

It's not the reason, it's the benefit effect if I joined.

I want to support @eslint-stylistic in the long term

---

Of course, that's totally OK if you don't accept this.