/
prefer-readonly-type-alias.ts
225 lines (205 loc) · 5.45 KB
/
prefer-readonly-type-alias.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
import type { TSESTree } from "@typescript-eslint/experimental-utils";
import type { JSONSchema4 } from "json-schema";
import { isReadonly, RuleContext, RuleMetaData, RuleResult } from "~/util/rule";
import { createRule } from "~/util/rule";
// The name of this rule.
export const name = "prefer-readonly-type-alias" as const;
const enum RequiredReadonlyness {
READONLY,
MUTABLE,
EITHER,
}
// The options this rule can take.
type Options = {
readonly mustBeReadonly: {
readonly pattern: ReadonlyArray<string> | string;
readonly requireOthersToBeMutable: boolean;
};
readonly mustBeMutable: {
readonly pattern: ReadonlyArray<string> | string;
readonly requireOthersToBeReadonly: boolean;
};
};
// The schema for the rule options.
const schema: JSONSchema4 = [
{
type: "object",
properties: {
mustBeReadonly: {
type: "object",
properties: {
pattern: {
type: ["string", "array"],
items: {
type: "string",
},
},
requireOthersToBeMutable: {
type: "boolean",
},
},
additionalProperties: false,
},
mustBeMutable: {
type: "object",
properties: {
pattern: {
type: ["string", "array"],
items: {
type: "string",
},
},
requireOthersToBeReadonly: {
type: "boolean",
},
},
additionalProperties: false,
},
},
additionalProperties: false,
},
];
// The default options for the rule.
const defaultOptions: Options = {
mustBeReadonly: {
pattern: "^Readonly",
requireOthersToBeMutable: false,
},
mustBeMutable: {
pattern: "^Mutable",
requireOthersToBeReadonly: true,
},
};
// The possible error messages.
const errorMessages = {
mutable: "Mutable types should not be fully readonly.",
readonly: "Readonly types should not be mutable at all.",
mutableReadonly:
"Configuration error - this type must be marked as both readonly and mutable.",
needExplicitMarking:
"Type must be explicity marked as either readonly or mutable.",
} as const;
// The meta data for this rule.
const meta: RuleMetaData<keyof typeof errorMessages> = {
type: "suggestion",
docs: {
description: "Prefer readonly type alias over mutable one.",
category: "Best Practices",
recommended: "error",
},
messages: errorMessages,
fixable: "code",
schema,
};
/**
* Check if the given TypeReference violates this rule.
*/
function checkTypeAliasDeclaration(
node: TSESTree.TSTypeAliasDeclaration,
context: RuleContext<keyof typeof errorMessages, Options>,
options: Options
): RuleResult<keyof typeof errorMessages, Options> {
const mustBeReadonlyPatterns = (
Array.isArray(options.mustBeReadonly.pattern)
? options.mustBeReadonly.pattern
: [options.mustBeReadonly.pattern]
).map((pattern) => new RegExp(pattern, "u"));
const mustBeMutablePatterns = (
Array.isArray(options.mustBeMutable.pattern)
? options.mustBeMutable.pattern
: [options.mustBeMutable.pattern]
).map((pattern) => new RegExp(pattern, "u"));
const patternStatesReadonly = mustBeReadonlyPatterns.some((pattern) =>
pattern.test(node.id.name)
);
const patternStatesMutable = mustBeMutablePatterns.some((pattern) =>
pattern.test(node.id.name)
);
if (patternStatesReadonly && patternStatesMutable) {
return {
context,
descriptors: [
{
node: node.id,
messageId: "mutableReadonly",
},
],
};
}
if (
!patternStatesReadonly &&
!patternStatesMutable &&
options.mustBeReadonly.requireOthersToBeMutable &&
options.mustBeMutable.requireOthersToBeReadonly
) {
return {
context,
descriptors: [
{
node: node.id,
messageId: "needExplicitMarking",
},
],
};
}
const requiredReadonlyness =
patternStatesReadonly ||
(!patternStatesMutable && options.mustBeMutable.requireOthersToBeReadonly)
? RequiredReadonlyness.READONLY
: patternStatesMutable ||
(!patternStatesReadonly &&
options.mustBeReadonly.requireOthersToBeMutable)
? RequiredReadonlyness.MUTABLE
: RequiredReadonlyness.EITHER;
return checkRequiredReadonlyness(
node,
context,
options,
requiredReadonlyness
);
}
function checkRequiredReadonlyness(
node: TSESTree.TSTypeAliasDeclaration,
context: RuleContext<keyof typeof errorMessages, Options>,
options: Options,
requiredReadonlyness: RequiredReadonlyness
): RuleResult<keyof typeof errorMessages, Options> {
if (requiredReadonlyness !== RequiredReadonlyness.EITHER) {
const readonly = isReadonly(node.typeAnnotation, context);
if (readonly && requiredReadonlyness === RequiredReadonlyness.MUTABLE) {
return {
context,
descriptors: [
{
node: node.id,
messageId: "readonly",
},
],
};
}
if (!readonly && requiredReadonlyness === RequiredReadonlyness.READONLY) {
return {
context,
descriptors: [
{
node: node.id,
messageId: "mutable",
},
],
};
}
}
return {
context,
descriptors: [],
};
}
// Create the rule.
export const rule = createRule<keyof typeof errorMessages, Options>(
name,
meta,
defaultOptions,
{
TSTypeAliasDeclaration: checkTypeAliasDeclaration,
}
);