From 13c69e49a2a7310492d93f849a83effda75e1eb7 Mon Sep 17 00:00:00 2001 From: Adrian Li Date: Thu, 6 Sep 2018 21:26:02 -0700 Subject: [PATCH 1/2] remove fixer and associated tests --- __tests__/param-names.js | 12 ++++-------- rules/param-names.js | 8 +------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/__tests__/param-names.js b/__tests__/param-names.js index d914967f..6d746717 100644 --- a/__tests__/param-names.js +++ b/__tests__/param-names.js @@ -22,23 +22,19 @@ ruleTester.run('param-names', rule, { invalid: [ { code: 'new Promise(function(reject, resolve) {})', - errors: [{ message }], - output: 'new Promise(function(resolve, reject) {})' + errors: [{ message }] }, { code: 'new Promise(function(resolve, rej) {})', - errors: [{ message }], - output: 'new Promise(function(resolve, reject) {})' + errors: [{ message }] }, { code: 'new Promise(yes => {})', - errors: [{ message }], - output: 'new Promise(resolve => {})' + errors: [{ message }] }, { code: 'new Promise((yes, no) => {})', - errors: [{ message }], - output: 'new Promise((resolve, reject) => {})' + errors: [{ message }] } ] }) diff --git a/rules/param-names.js b/rules/param-names.js index c1633cfc..b16d73ab 100644 --- a/rules/param-names.js +++ b/rules/param-names.js @@ -26,13 +26,7 @@ module.exports = { context.report({ node, message: - 'Promise constructor parameters must be named resolve, reject', - fix(fixer) { - return [ - fixer.replaceText(params[0], 'resolve'), - params[1] && fixer.replaceText(params[1], 'reject') - ].filter(Boolean) - } + 'Promise constructor parameters must be named resolve, reject' }) } } From c75be1f0f2da1893465e813a196861f08c697db7 Mon Sep 17 00:00:00 2001 From: Adrian Li Date: Thu, 6 Sep 2018 21:28:57 -0700 Subject: [PATCH 2/2] update README to show that param-names is no longer autofixed --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1bf3d00a..0ef515aa 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ or start with the recommended rule set: | -------------------------------------------------------- | -------------------------------------------------------------------------------- | ----------- | -------- | | [`catch-or-return`][catch-or-return] | Enforces the use of `catch()` on un-returned promises. | :bangbang: | | | [`no-return-wrap`][no-return-wrap] | Avoid wrapping values in `Promise.resolve` or `Promise.reject` when not needed. | :bangbang: | | -| [`param-names`][param-names] | Enforce consistent param names and ordering when creating new promises. | :bangbang: | :wrench: | +| [`param-names`][param-names] | Enforce consistent param names and ordering when creating new promises. | :bangbang: | | | [`always-return`][always-return] | Return inside each `then()` to create readable and reusable Promise chains. | :bangbang: | | | [`no-native`][no-native] | In an ES5 environment, make sure to create a `Promise` constructor before using. | | | | [`no-nesting`][no-nesting] | Avoid nested `then()` or `catch()` statements | :warning: | |