From 16c4aa45c51103496bb8e2340c7533da128d24ac Mon Sep 17 00:00:00 2001 From: Macklin Underdown Date: Mon, 12 Mar 2018 12:04:16 -0400 Subject: [PATCH] feat: turn off avoid-new in recommended configuration See #111 --- README.md | 2 +- index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d9029ade..049ce616 100644 --- a/README.md +++ b/README.md @@ -88,7 +88,7 @@ or start with the recommended rule set | [`no-nesting`][no-nesting] | Avoid nested `then()` or `catch()` statements | :warning: | | | [`no-promise-in-callback`][no-promise-in-callback] | Avoid using promises inside of callbacks | :warning: | | | [`no-callback-in-promise`][no-callback-in-promise] | Avoid calling `cb()` inside of a `then()` (use [nodeify][] instead) | :warning: | | -| [`avoid-new` ][avoid-new] | Avoid creating `new` promises outside of utility libs (use [pify][] instead) | :warning: | | +| [`avoid-new`][avoid-new] | Avoid creating `new` promises outside of utility libs (use [pify][] instead) | | | | [`no-new-statics`][no-new-statics] | Avoid calling `new` on a Promise static method | :bangbang: | | | [`no-return-in-finally`][no-return-in-finally] | Disallow return statements in `finally()` | :warning: | | | [`valid-params`][valid-params] | Ensures the proper number of arguments are passed to Promise functions | :warning: | | diff --git a/index.js b/index.js index c849c704..18e3bd2d 100644 --- a/index.js +++ b/index.js @@ -35,7 +35,7 @@ module.exports = { 'promise/no-nesting': 'warn', 'promise/no-promise-in-callback': 'warn', 'promise/no-callback-in-promise': 'warn', - 'promise/avoid-new': 'warn', + 'promise/avoid-new': 'off', 'promise/no-new-statics': 'error', 'promise/no-return-in-finally': 'warn', 'promise/valid-params': 'warn'