Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unforking this repository #55

Closed
jordanbtucker opened this issue Sep 30, 2022 · 10 comments
Closed

Consider unforking this repository #55

jordanbtucker opened this issue Sep 30, 2022 · 10 comments

Comments

@jordanbtucker
Copy link

This repository is currently forked from https://github.com/mysticatea/eslint-plugin-node, which makes it impossible to search code via GitHub. Since the original repository is stale, I'm not sure there is a point to keep it forked.

I recommend unforking this repository to enable code search.

@voxpelli
Copy link
Member

The current plan is to give some additional time to the original project owner to donate his project to this org.

After that time has passed I agree that this is what we should do.

@goosewobbler
Copy link

The original project owner couldn't be bothered to even respond once to anything regarding this project since abandoning it almost 3 years ago, despite being chased around github, but sure, let's wait another couple of years just in case, have to avoid hurting feelings 😅

@privatenumber
Copy link

@goosewobbler

The original project owner couldn't be bothered to even respond once to anything regarding this project since abandoning it almost 3 years ago, despite being chased around github, but sure, let's wait another couple of years just in case, have to avoid hurting feelings 😅

The JavaScript community has benefited greatly from @mysticatea's work over the years. His work is extremely high quality & technical and he's been a reliable and respectable maintainer for many open source projects. I don't think anyone working hard to improve the ecosystem deserves that kind of treatment. Let's try to be more respectful and empathetic.

All of his recent GitHub activities are commits to mysticatea/eslint-evaluating-issues, but when you look closer, they're actually all automated via GitHub Actions. The last commit other than that is eslint/eslint@808ad35, which was caused by someone else merging his PR. I'm not going to dig deeper but I think it's safe to assume he hasn't been on GitHub in a year. I also checked his Twitter and he hasn't been active there since Oct 2021 (last "Like").

I don't want to pry, but everyone has a life outside of open source and you never know what circumstances they're dealing with.

I would move on with unforking, and just hope he comes back one day. 🤞

@goosewobbler
Copy link

The JavaScript community has benefited greatly from @mysticatea's work over the years. His work is extremely high quality & technical and he's been a reliable and respectable maintainer for many open source projects. I don't think anyone working hard to improve the ecosystem deserves that kind of treatment. Let's try to be more respectful and empathetic.

Fair enough, and I see the ridiculous number of repos on @mysticatea's account. But anyone simply trying to use the library does not have this context.

I don't want to pry, but everyone has a life outside of open source and you never know what circumstances they're dealing with.

Absolutely, and yet, if I started a popular repo and had to quickly leave github and social media, I would at least hand it over to someone (anyone) else. If there was not enough time to consider that then I would expect (and hope) for my project to be forked and then started anew as soon as possible. If only so that I would not have to consider dealing with it again or having people trying to contact me.

I would move on with unforking, and just hope he comes back one day. 🤞

This was my original point. The original repo is just really out of date. If he comes back and wants to be involved again, I'm sure the current owner will let him be reinstated as project owner of this new project.

@voxpelli
Copy link
Member

let's wait another couple of years just in case, have to avoid hurting feelings 😅

Skip the sarcasm 🙏

We want to follow due process as eg. outlined in the RFC and be open to maintainers about our intent before we make a final decision.

Now it has been more than 30, even more than 60, days and yeah, we should move forward with this

@voxpelli
Copy link
Member

@MichaelDeBoey Do you want to do this for all of the projects? Else I go ahead and ask for this + eslint-community/regexpp#33 + maybe the rest of the ones forked from the same maintainer? https://github.com/eslint-community?type=fork

@MichaelDeBoey
Copy link
Member

@voxpelli I don't see any harm in keeping the fork status tbh as it's clearly a fork of the original one 🤷‍♂️
Are there any specific things we currently can't do because it's still a fork?

Keeping the fork also keeps the extra link on the original repo + people coming by this repo can see that it's a maintained fork instead of a new repo with about the same name

@jordanbtucker
Copy link
Author

Keeping the fork makes it impossible to search the code in the repo on GitHub, unless they've fixed that recently.

@MichaelDeBoey
Copy link
Member

@jordanbtucker Can you give some examples of what you're trying to look for?
All the things I just tested, just seem to work

@jordanbtucker
Copy link
Author

Seems like search is working for forked repos now. At least for this repo. GitHub must have fixed that since I opened this issue. That was the only reason, so I don't mind closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants