Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪶 Use ts-ignore-import to lighten the dependencies #213

Closed
scagood opened this issue Apr 5, 2024 · 3 comments · Fixed by #219
Closed

🪶 Use ts-ignore-import to lighten the dependencies #213

scagood opened this issue Apr 5, 2024 · 3 comments · Fixed by #219

Comments

@scagood
Copy link

scagood commented Apr 5, 2024

Following up on this comment: #169 (comment 1546863039)

We have decided that it'll be best to use voxpelli/ts-ignore-import to be able to mark all types as optional peer dependencies.

Our peerDependencies will then look like:

"peerDependencies": {
  "@types/eslint": ">=8"
  "eslint": ">=8"
},
"peerDependenciesMeta": {
  "@types/eslint": {
    "optional": true
  }
}
@voxpelli
Copy link
Member

voxpelli commented Apr 7, 2024

@scagood You want to do a PR or should I?

@scagood
Copy link
Author

scagood commented Apr 7, 2024

I want to PR #182 currently, as its got me a second time 😅

Could you take this one on?

@voxpelli voxpelli self-assigned this Apr 7, 2024
@voxpelli
Copy link
Member

voxpelli commented Apr 7, 2024

@scagood I'll do one right away 👍

aladdin-add pushed a commit that referenced this issue Apr 8, 2024
* chore: use `ts-ignore-import` to lighten the dependencies

Fixes #213

* Fix

* chore: remove `@types/eslint` from `dependencies`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants