From caecf3ebeea5aab9edf248935250691e6065724d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=94=AF=E7=84=B6?= Date: Wed, 24 Apr 2024 21:36:23 +0800 Subject: [PATCH] Revert "fix: unsupported-features/node-builtins-modules range compare" (#254) Revert "fix: unsupported-features/node-builtins-modules range compare (#252)" This reverts commit d50ae85c209a47a8a5d4c1bedaa94e6a77540095. --- lib/util/check-unsupported-builtins.js | 3 +-- .../no-unsupported-features/es-builtins.js | 17 ----------------- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/lib/util/check-unsupported-builtins.js b/lib/util/check-unsupported-builtins.js index e76a5e39..db2ae46f 100644 --- a/lib/util/check-unsupported-builtins.js +++ b/lib/util/check-unsupported-builtins.js @@ -9,7 +9,6 @@ const { ReferenceTracker } = require("@eslint-community/eslint-utils") const getConfiguredNodeVersion = require("./get-configured-node-version") const getSemverRange = require("./get-semver-range") const unprefixNodeColon = require("./unprefix-node-colon") -const semverRangeSubset = require("semver/ranges/subset") /** * Parses the options. @@ -51,7 +50,7 @@ function isSupported({ supported }, configured) { return false } - return semverRangeSubset(configured, range) + return configured.intersects(range) } /** diff --git a/tests/lib/rules/no-unsupported-features/es-builtins.js b/tests/lib/rules/no-unsupported-features/es-builtins.js index a78c9cce..1ca57dd1 100644 --- a/tests/lib/rules/no-unsupported-features/es-builtins.js +++ b/tests/lib/rules/no-unsupported-features/es-builtins.js @@ -2424,23 +2424,6 @@ runTests([ }, ], }, - // https://github.com/eslint-community/eslint-plugin-n/issues/250 - { - code: "function wrap() { globalThis }", - settings: { - node: { version: ">=11.9.9" }, - }, - errors: [ - { - messageId: "not-supported-till", - data: { - name: "globalThis", - supported: "12.0.0", - version: ">=11.9.9", - }, - }, - ], - }, ], }, ])