Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use node protocol until we drop Node v14.17 support #315

Merged
merged 1 commit into from Oct 13, 2022
Merged

fix: don't use node protocol until we drop Node v14.17 support #315

merged 1 commit into from Oct 13, 2022

Conversation

bmish
Copy link
Member

@bmish bmish commented Oct 13, 2022

We can't use Node protocol imports until we drop support for Node 14.17 (https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md).

This issue was caught in: #313

This bug was added in: #302

@bmish bmish added the bug label Oct 13, 2022
@bmish bmish mentioned this pull request Oct 13, 2022
Closed
@MichaelDeBoey MichaelDeBoey changed the title Fix Node 14.17 support fix: don't use node protocol until we drop Node v14.17 support Oct 13, 2022
@bmish bmish merged commit a5c0b0c into main Oct 13, 2022
@bmish bmish deleted the remove-node-protocol-import branch October 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
bug hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @MichaelDeBoey