This repository was archived by the owner on Feb 21, 2025. It is now read-only.
Improve caching of downloaded Gradle distributions #55
+1,341
−994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates transitive library versions to address known vulnerabilities
Get latest versions of transitive deps.
- Use built-in `hashFiles` function included in '@actions/globv0.2.0' - Use `downloadTool` and `extractZip` functions from '@actions/tool-cache'
- Remove the 'gradle --stop' step from the prod workflow. We either need to stop all instances started, or rely on GitHub to clean up processes on completion. - Remove configuration-cache and dependencies-cache from basic tests. We will later need to add tests invocations specific for these features.
This removes the need to specify `wrapper-directory` when using a Gradle project that is not located in the root of the workspace. Fixes #44.
- Upgraded `samples/basic` to use latest Gradle version.
Will use this for testing Gradle execution with different versions and mechanisms.
Use matrix to allow different script suffix on windows
- Provide a more useful error message when no Gradle wrapper can be located, and 'gradle-version' or 'gradle-executable' is not used. - Add test for case where wrapper is missing. This isn't really a "test" per-se, but this failing build invocation makes it easy to verify the GitHub action behaviour when the build is misconfigured.
In the (rare) case where using a non-default Gradle wrapper is required, the `gradle-executable` paramater can be used.
This makes the version alias match other places where we reference a release candidate version.
Prior to this change, the wrapper cache contained both the downloaded zip file as well as the exploded wrapper dir. Only the zip file is required, as Gradle will automatically detect and unpack.
- Cache is separate from (but similar to) the wrapper distribution cache - Renamed the 'wrapper-cache-enabled' flag to 'distributions-cache-enabled': this flag now controls both wrapper and regular distribution caching
|
I'm +1 on the changes! This PR breaks backwards compatibility of the workflows by removing/renaming inputs though. We have two options for this:
I'd be happy either way but backwards compatibility sounds good to me because we can ship improvements to people without requiring them to change their workflows. What do you think? |
|
Thanks @eskatos . I'm going to close this in order to separate the useful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapper-directoryoption: use thegradle-executableflag for this (uncommon) purposercoption torelease-candidatefor consistency with other resources