Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA Review: User Authentication #2

Open
17 of 19 tasks
esantos2 opened this issue May 1, 2020 · 3 comments
Open
17 of 19 tasks

PA Review: User Authentication #2

esantos2 opened this issue May 1, 2020 · 3 comments
Assignees

Comments

@esantos2
Copy link
Owner

esantos2 commented May 1, 2020

User Auth

Functionality

  • The main button with logo should link to /
  • Has working demo login
  • Smooth, bug free navigation

Before Login

  • The /login page should not display a link to Log In. Same for /signup
  • Going to a random route /#/oweiniouewbrviuwebv should redirect or display a 404 page
  • Errors should display for both /signup and /login.
  • Errors should clear when moving between /signup and /login.
  • Can sign up a user
  • Can sign in as a user
  • Can log out a user
  • Can't sign up with the same email
  • Pressing enter after filling out the session form should use the form data, not the demo user

After Login

  • Should not be able to visit /login or /signup
  • Should be able to refresh the page and still be logged in

Style

  • The site should look exactly like the actual site
  • All relevant elements should have cursor: pointer on hover
  • When errors are displayed, most elements should not move around the page (particularly input boxes)
  • Remove Redux logger and all console.log()'s from production

Seeds

  • Adequate and appropriate seeds
@jenvomo
Copy link

jenvomo commented May 1, 2020

Looking great @Arctive ! I'm getting 500 level server errors when trying to sign up. Let me know when that is fixed and I will check that it looks good and close this issue!

Well done! 👏

@esantos2
Copy link
Owner Author

esantos2 commented May 1, 2020

Thanks for checking @jenvomo! I've resolved the error, it should be working properly now.

@jenvomo
Copy link

jenvomo commented May 6, 2020

Almost done @Arctive ! Just need to remove logger and do the below styling:

  • style the dropdowns for region and language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants