Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.7.x] Fix spaces in class names #700

Merged
merged 2 commits into from Mar 17, 2019
Merged

[1.7.x] Fix spaces in class names #700

merged 2 commits into from Mar 17, 2019

Conversation

aidantwoods
Copy link
Collaborator

@aidantwoods aidantwoods mentioned this pull request Mar 17, 2019
Closed
@aidantwoods aidantwoods merged commit c390a9e into erusev:1.7.x Mar 17, 2019
@aidantwoods aidantwoods deleted the fix/spaces-in-class-names-1.7.x branch March 17, 2019 17:14
@stof
Copy link

stof commented Apr 10, 2019

shouldn't a test be added to prevent regressions on this ?

@aidantwoods
Copy link
Collaborator Author

I added a test in the WIP 2.0.x branch for the patch there (aidantwoods@3f74fe8), but yeah you're right—I'll add a test in this and the related PR later today :)

@aidantwoods
Copy link
Collaborator Author

3d2b25b 87b57bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aidantwoods @stof