Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug when rendering list #529

Closed
wanghanlin opened this issue Sep 15, 2017 · 2 comments
Closed

Possible bug when rendering list #529

wanghanlin opened this issue Sep 15, 2017 · 2 comments
Labels

Comments

@wanghanlin
Copy link

wanghanlin commented Sep 15, 2017

(new Parsedown)->text("- A\n\n- B\n\n- C\n\n")

this is parsed to

   <ul>\n
   <li>\n
   <p>A</p>\n
   </li>\n
   <li>\n
   <p>B</p>\n
   </li>\n
   <li>C</li>\n
   </ul>

while I think it should be parsed to

   <ul>\n
   <li>\n
   <p>A</p>\n
   </li>\n
   <li>\n
   <p>B</p>\n
   </li>\n
   <li>\n
   <p>C</p>\n
   </li>\n
   </ul>

is it a bug or I'm using the package wrongly? ref laravel/framework#21197

@aidantwoods
Copy link
Collaborator

I think this is a duplicate of #474. I probably won't be able to test this today, but does applying this patch from #475 solve this issue?

@wanghanlin
Copy link
Author

@aidantwoods Yes, I think that patch solves the problem, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants