Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is README outdated on Windows support? #29

Closed
danenania opened this issue Nov 16, 2023 · 2 comments
Closed

Is README outdated on Windows support? #29

danenania opened this issue Nov 16, 2023 · 2 comments

Comments

@danenania
Copy link

danenania commented Nov 16, 2023

Thanks for this library. The README says:

Windows is currently not explicitly supported because input events are dropped when running multiple prompts sequentially due to a bug in bubbletea. See charmbracelet/bubbletea#140 and charmbracelet/bubbletea#121 for more information.

But it seems these issues have been resolved in bubbletea. Does that mean that Windows is now supported and the README should be updated? Or perhaps the bubbletea dependency needs a version bump?

@erikgeiser
Copy link
Owner

Unfortunately, my PR that would have made it work was not merged because it was a big code change and after a while, the branches diverged too much.

The issue is that each promptkit prompt is a single bubbletea "program". This means that multiple prompts result in multiple programs. However, bubbletea assumes that you only ever run a single bubbletea program in the lifetime of your entire process. Initially, they used a hack to read the input that resulted in a buggy input for subsequent bubbletea programs. I was able to fix that for Unix-like OSs but the fix for Windows needed a much larger redesign which was ultimately not merged.

@danenania
Copy link
Author

I see, thanks for the explanation @erikgeiser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants