Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "dataclasses.replace broken if a class has any ClassVars" in backport #143

Closed
gnillev opened this issue Feb 22, 2019 · 6 comments
Closed

Comments

@gnillev
Copy link

gnillev commented Feb 22, 2019

This bug https://bugs.python.org/issue33796 is still present in version 0.6 of the backport.
It would be nice to have a new backport version with the fix included.

@AstraLuma
Copy link

Bump, ran into this in ppb-vector.

@anthrotype
Copy link

@ericvsmith can we please have a new release of dataclasses backport with the fix in #140 for ClassVar and .replace()? Thank you!!!

@anthrotype
Copy link

@ericvsmith Can you please cut a new release with #140 included? I need to use ClassVars with dataclasses and this prevents me from supporting python 3.6... I'm tempted to drop support for it altogether.

@ericvsmith
Copy link
Owner

@anthrotype : I've pushed 0.8 to PyPI. Please take a look.

@anthrotype
Copy link

now it works! thank you very much 👍

@ericvsmith
Copy link
Owner

No problem. Sorry for the extensive delay.

anthrotype added a commit to googlefonts/nanoemoji that referenced this issue Nov 13, 2020
anthrotype added a commit to googlefonts/nanoemoji that referenced this issue Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants